Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map generation: Strict check on SUBDOMAIN_INSTALL fails #188

Closed
ChrisHardie opened this issue Mar 16, 2019 · 0 comments
Closed

Map generation: Strict check on SUBDOMAIN_INSTALL fails #188

ChrisHardie opened this issue Mar 16, 2019 · 0 comments

Comments

@ChrisHardie
Copy link
Contributor

The commit f29005c introduced a strict comparison for the check that the Multisite setup is using a SUBDOMAIN_INSTALL at https://github.com/rtCamp/nginx-helper/blob/master/admin/class-nginx-helper-admin.php#L502.

Unfortunately while the non-strict check against yes was succeeding in the past when SUBDOMAIN_INSTALL is true, the strict check does not, taking the map generation into the subdirectory code path. This produces unexpected results, including an invalid "path" value where a domain value is expected in the map entry for any site that doesn't have a domain mapped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant