Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed of the agent #108

Closed
BDonnot opened this issue May 28, 2020 · 1 comment
Closed

Add seed of the agent #108

BDonnot opened this issue May 28, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@BDonnot
Copy link
Collaborator

BDonnot commented May 28, 2020

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

For now, everything can be seeded to have reproducible experiments. The environment, the chronics etc (some seeding are missing in VoltageHandler and Opponent).

But the "seed" feature is missing from the Agent interface. This can be problematic for some experiments.

Describe the solution you'd like

Add the seed() method into the Agent public API.

Modify the runner so that you can set the seed of the agent from there.

Rewrite notebook 4 so that it is correct (for now it's not correct at all).

@BDonnot BDonnot added the enhancement New feature or request label May 28, 2020
@BDonnot BDonnot mentioned this issue May 29, 2020
@BDonnot
Copy link
Collaborator Author

BDonnot commented May 29, 2020

Fixed in 0.9.3

@BDonnot BDonnot closed this as completed May 29, 2020
BDonnot added a commit that referenced this issue Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant