You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't look like this repo is maintained, nor PRs looked at, so here are some things other readers of the book might find useful:
most importantly, Pasta functionality doesn't work anymore due to code removed after ch 6 from index.html i.e. app.ports.setFilters.subscribe & Pasta.addActivityListener; unfortunately it's not just this, the ports logic probably needs to go through Main.elm so this feels like a big knowledge gap;
SelectPhotoUrl doesn't exist and should be ClickedPhoto in PhotoFolders, line 133 - fixed by Fixing action names #8, but not merged in almost a year
ToggleExpanded doesn't exist and should be ClickedFolder in PhotoFolders, line 147 - fixed by the same PR as above
ambiguous imports in PhotoGallery for required & list - this might be a regression between Elm 0.19.0 and 0.19.1 but I haven't tested with 0.19.0; use fully qualified names and you should be fine
there is a mention in the book about the renaming the tests file to make them run, but you also need to re-expose the tested methods
If anyone gets the Pasta stuff working, it would be great to share the required changes.
The text was updated successfully, but these errors were encountered:
It doesn't look like this repo is maintained, nor PRs looked at, so here are some things other readers of the book might find useful:
app.ports.setFilters.subscribe
&Pasta.addActivityListener
; unfortunately it's not just this, theports
logic probably needs to go throughMain.elm
so this feels like a big knowledge gap;SelectPhotoUrl
doesn't exist and should beClickedPhoto
in PhotoFolders, line 133 - fixed by Fixing action names #8, but not merged in almost a yearToggleExpanded
doesn't exist and should beClickedFolder
in PhotoFolders, line 147 - fixed by the same PR as aboverequired
&list
- this might be a regression between Elm 0.19.0 and 0.19.1 but I haven't tested with 0.19.0; use fully qualified names and you should be fineIf anyone gets the Pasta stuff working, it would be great to share the required changes.
The text was updated successfully, but these errors were encountered: