Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scopes issue #9

Open
jeop10 opened this issue Aug 26, 2018 · 0 comments
Open

Scopes issue #9

jeop10 opened this issue Aug 26, 2018 · 0 comments

Comments

@jeop10
Copy link

jeop10 commented Aug 26, 2018

Hello!

First let me just say thank you for creating this amazing library, now I have been testing some things and I needed to set de 'save' scope and I went on and did this:

$reddit = new Reddit([
   . . .
    'scopes'        => ['identity', 'read', 'save'],
]);

But this does not add the save scope, I went on and looking to the code I can see that the variable its not call scopes but scope and you need to add it when you are calling the method to get the authorizationURL, like this:

$reddit->client->getAuthorizationUrl([
            'duration' => 'permanent',  // "permanent" or "temporary" by default
            'scope'        => ['identity', 'read', 'save'],
        ]); 

Did I make something wrong? Is this the intended behaviour? Should I make a merge request to update the documentation or maybe Should I try to fix it on the code itself so the code works just like explained on the docs?

Thanks again

@jeop10 jeop10 closed this as completed Nov 10, 2018
@jeop10 jeop10 reopened this Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant