Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution for the case of "epoch flag == 5" #556

Open
schumipush opened this issue Jan 7, 2025 · 3 comments
Open

solution for the case of "epoch flag == 5" #556

schumipush opened this issue Jan 7, 2025 · 3 comments

Comments

@schumipush
Copy link

Is the symbol "<=" correct?

To my understanding, if (fabs(timediff(data[0].time,time1)-dtime1)>=DTTOL), then the new ely read epoch is valid. So why do you want to discard the current epoch data and read the next epoch in turn?

if (fabs(timediff(data[0].time,time1)-dtime1)>=DTTOL)

@ourairquality
Copy link

Fwiw this code is specific to time events, when flag is 5, so does not affect common uses. At a guess it was to assign the event to a set of observation data, but it needs some work. It does not appear that the events are used for anything. Perhaps the only code paths tested were the output paths, to get events from the receiver data into rinex files.

@schumipush
Copy link
Author

@ourairquality Thanks for your response! I think there might be an underlying assumption that with a flag of 5, the observations in next epoch might be unhealthy or of poor quality. Subsequently, if the next epoch does not occur at the established interval, the epoch is considered unavailable and skips to the next epoch. What do you think?

@ourairquality
Copy link

The flag of 5 is just the rinex epoch event flag, and for 5 that is an 'external event'. There is no reason that the next epoch would be of poor quality, there is no reason to skip an epoch. If you don't need to handle external events then I would not bother over that code, and if you do then you might want to reconsider the entire implementation and the various code paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants