Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct install path for libraries -> lib instead of bin #102

Closed
wants to merge 2 commits into from

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Jan 21, 2018

Self explaining I think, or should the libraries really go into the bin folder?

@acki-m
Copy link
Contributor

acki-m commented Jan 21, 2018

Yes, it has to be.
Otherwise the applications cannot be executed (like the examples or bench tools, or even unit_tests)
Because of missing libraries.

@gabyx
Copy link
Contributor Author

gabyx commented Jan 21, 2018

dont understand, because on linux and macos mostly we put the library in /lib
is that thing here not putting them in /bin?

install(TARGETS rttr_core EXPORT rttr_targets
                RUNTIME DESTINATION ${RTTR_BIN_INSTALL_DIR}
                LIBRARY DESTINATION ${RTTR_BIN_INSTALL_DIR}
                ARCHIVE DESTINATION ${RTTR_LIB_INSTALL_DIR})

I think one should rather, edit the "rpath" in the executable instead of just copying the stuff next to the executable, I think cmake handles that (its kind of complicated, and I dont understand yet everything) when installing . Mostly the user anyway does not want to install the tests/benchmarks (maybe the examples)?
https://cmake.org/Wiki/CMake_RPATH_handling

@gabyx
Copy link
Contributor Author

gabyx commented Jan 21, 2018

I think its very related to #101 ...

@coveralls
Copy link

coveralls commented Jan 21, 2018

Coverage Status

Coverage remained the same at 91.566% when pulling adf2463 on gabyx:correct-cmake-install into 47d576c on rttrorg:master.

@gabyx
Copy link
Contributor Author

gabyx commented Jan 23, 2018

same as #103

@gabyx gabyx closed this Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants