Migration from 0.4.0 to 1.1.0 fails because of the <span> tag in 1.1.0

[wingedfox]

Hi,

Is there an easy way to migrate from 0.4.0 to 1.1.0?
As long as 1.1.0 starts to add with translated string, it fails in certail scenarios like

  <option translate>default</option>

which ends up with

  <option translate>
    <span class="ng-scope">Default value</span>
  </option>

[rubenv]

Is this causing problems for you?

We're doing exactly that in a project, without issues:

[wingedfox]

Yes, this causes different problems with migration, mainly with the autotests, but we met the side effects too with the <title> and <textarea>.

For sure, starting right from 1.0 we will consider this as a feature, but now I'll be glad to see a sort of migration guide.

[circlingthesun]

The reason why the translation gets wrapped in a span tag probably has something to do with https://github.com/rubenv/angular-gettext/blob/master/src/directive.js#L49. The translation is wrapped because angular.element() fails when given text. Further down element.contents() should extract the translation from the wrapping and replace the existing translation. For some reason here the translation is still wrapped when swapped in.

[circlingthesun]

It seems $compile wraps root text elements in span's so that it can attach data elements. (angular/angular.js#1059)

[circlingthesun]

Angular 1.6 fixes the span issue. See:
Spans in 1.5.9: http://plnkr.co/edit/tKloB8LFk3GCAsu0UEUx?p=preview
No spans in 1.6.0: http://plnkr.co/edit/tE96QrOPtqxuxR4xbxRL?p=preview

[wingedfox]

Great to see this fixed =)