Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gorp dependency to gorp.v2 #205

Open
jamesatwill-okta opened this issue Jan 25, 2022 · 8 comments
Open

Update gorp dependency to gorp.v2 #205

jamesatwill-okta opened this issue Jan 25, 2022 · 8 comments

Comments

@jamesatwill-okta
Copy link

Hi! Could I convince you to migrate from gorp.v1 to gorp.v2?

There's only one note in the migration guide: https://github.com/go-gorp/gorp#pre-v2-to-v2

@rubenv
Copy link
Owner

rubenv commented Jan 27, 2022

It's probably about time we do that indeed!

Could you send a PR?

@idcmp
Copy link
Contributor

idcmp commented Jan 27, 2022

#206 bumps to the latest gorp which is backwards compatible with v2.2.0 except it cleans up its go.mod handling. HTH!

@rubenv
Copy link
Owner

rubenv commented Jan 28, 2022

Closed in #206, thanks @idcmp

@wonsikin
Copy link

@jamesatwill-okta @rubenv
Found an issue after #206 was merged

$ go get -v github.com/rubenv/sql-migrate/...
github.com/rubenv/sql-migrate (download)
github.com/go-gorp/gorp (download)
package github.com/rubenv/sql-migrate: cannot find package "github.com/go-gorp/gorp/v3" in any of:
	/usr/local/go/src/github.com/go-gorp/gorp/v3 (from $GOROOT)
	/go/src/github.com/go-gorp/gorp/v3 (from $GOPATH)

@slee500
Copy link

slee500 commented Jan 31, 2022

@wonsikin Had the same error too. If you do export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/... this fixes the issue.

@joj0hq
Copy link

joj0hq commented Jan 31, 2022

@slee500 @wonsikin
I did export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/....
But I had same error too.
My Golang version is 1.15.0.

@joj0hq
Copy link

joj0hq commented Feb 1, 2022

I'm sorry. I had mistake.
If you do export GO111MODULE=on before running go get -v github.com/rubenv/sql-migrate/... this fixes the issue.
But I don't know this reason.

@slee500
Copy link

slee500 commented Feb 15, 2022

@jotaro-biz here's a good writeup on what export GO111MODULE=on does.
https://maelvls.dev/go111module-everywhere/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants