Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:: ligature request (tighter spacing) #38

Closed
mingaldrichgan opened this issue Sep 21, 2019 · 5 comments
Closed

:: ligature request (tighter spacing) #38

mingaldrichgan opened this issue Sep 21, 2019 · 5 comments
Labels
enhancement New feature or request testing
Milestone

Comments

@mingaldrichgan
Copy link
Contributor

Thank you for this amazing font! I'm curious if you've considered, or would consider, adding a ligature for :: with tighter spacing between the two colons (like Fira Code does)?

@rubjo
Copy link
Owner

rubjo commented Sep 22, 2019

Sure, why not. To be included in the next release.

If there are other character combos that you feel could benefit from being ligatures, feel free to make some more issues.

@rubjo rubjo added this to the 1.2.7 milestone Sep 22, 2019
@rubjo rubjo added the enhancement New feature or request label Sep 22, 2019
@mingaldrichgan
Copy link
Contributor Author

If there are other character combos that you feel could benefit from being ligatures, feel free to make some more issues.

Coming from Fira Code, I'm tempted to say that parity with their ligatures would be nice but I'm sure you don't agree with all of their decisions. 😄

@rubjo
Copy link
Owner

rubjo commented Sep 22, 2019

As I’d like to create them from scratch, it’s mainly a fair bit of work and will have to be done in stages.

I don’t know if I’m going to go down the «make any possible combo a ligature» path. I’m questioning the usefulness / added value for some of the ligatures - although I guess that’s a common sentiment against ligatures in general.

I’ll try to make a list of a handful of ligatures it is natural to start with, and include those in the next release.

@rubjo rubjo added the in progress Under development label Sep 25, 2019
@tomByrer
Copy link
Contributor

I’m questioning the usefulness / added value for some of the ligatures

I find ligatures for !=, => & === super helpful when scanning code. <=, >=, & <!-- are also helpful. I keep expecting a /> ligature, though I can not say it is much use.

I don't find your := helpful, since my eyes make it look like *=. I like Fira's exaggerated : , ; & := since those characters I use often.

@rubjo
Copy link
Owner

rubjo commented Sep 30, 2019

:= is slated to be less cramped in the next release.

Sent with GitHawk

@rubjo rubjo added testing and removed in progress Under development labels Oct 8, 2019
@rubjo rubjo closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

3 participants