Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post_condition_loop? and loop_keyword? for Node #36

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

Copy link
Contributor

@marcandre marcandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.
Would you please add a test where loop? is falsey?
I'm wondering if loop_keyword? wouldn't be clearer, as loop {} does not loop?...

@fatkodima fatkodima changed the title Add post_condition_loop? and loop? for Node Add post_condition_loop? and loop_keyword? for Node Jun 15, 2020
@fatkodima
Copy link
Contributor Author

Added falsey tests for SendNode.
Changed loop? to loop_keyword?.
Let me know if post_condition_loop? should be also changed.

@fatkodima fatkodima requested a review from marcandre June 15, 2020 09:21
@marcandre marcandre merged commit e70a53f into rubocop:master Jun 26, 2020
@marcandre
Copy link
Contributor

Sorry for the delay. Good work. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants