presence cop: fix [] for ternary expr other hand #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! That will definitely solve one issue. Could you add the changelog entry to CHANGELOG.md? |
|
This PR has been merged and I added the changelog entry for this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synopsis
when trying autofix code like below:
params[:foo].present? ? params[:foo] : params[:bar]the existing code will change it to:
params[:foo].presence || params(:bar)essentially replaces the content of the
elseorotherend of the ternary expression.investigation and fix
the culprit is this method
build_source_for_or_methoddid not consider the parameterother(which is aSendNode) might be a[]method call.this tiny patch fixes it.
That being said, I am not confident that this fixes all related problems.