Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for RuboCop 0.81 or lower #258

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

koic
Copy link
Member

@koic koic commented Jun 8, 2020

Follow up to rubocop/rubocop-performance#111.

This PR prepares to use RuboCop's new development API.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up to rubocop/rubocop-performance#111.

This PR prepares to use RuboCop's new development API.
@koic koic merged commit a7d0605 into rubocop:master Jun 8, 2020
@koic koic deleted the drop_support_rubocop_for_0_81_or_lower branch June 8, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant