Drop support for MRI 2.1 #5990

Drenmi · 2018-06-12T06:42:33Z

MRI 2.1 has been EOL for over one year. Time to drop official support? 🙂

Before submitting the PR make sure the following are checked:

Wrote good commit messages.
Commit message starts with [Fix #issue-number] (if the related issue exists).
Feature branch is up-to-date with master (if not - rebase it).
Squashed related commits together.
Added tests.
Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Darhazer · 2018-06-12T07:23:33Z

Gemfile

@@ -6,8 +6,7 @@ gemspec

 gem 'bump', require: false
 gem 'pry'
-# pry-byebug requires MRI 2.2.0 or higher.
-gem 'pry-byebug' if RUBY_ENGINE == 'ruby' && RUBY_VERSION >= '2.2.0'
+gem 'pry-byebug'


guess you still need to check for MRI

Seems like it. 🙂

pocke · 2018-06-12T08:18:12Z

I totally agree that dropping support for Ruby 2.1 form runtime, but I'm not sure we should drop it from the target ruby versions.

We will be able to use new Ruby features by dropping support for old Rubies. I think it is a very big advantage. And RuboCop users can use RuboCop only with new Rubies. For example, users can disable RuboCop with Ruby 2.1 on Travis CI by the build matrix feature.

However, personally I think dropping it from target ruby versions hardly has advantages for us. We can use new Ruby features without dropping.
And probably RuboCop users will retire updatung RuboCop by this change. Especially many libraries support old Rubies unfortunately. So libraries owners will not be able to update RuboCop by this change. I think it is a big disadvantage.

I got the same comment from a library owner when we dropped Ruby 2.0.

I don't watch all issues of RuboCop recently because I'm busy. So sorry if you have discussed the comment already.

Drenmi · 2018-06-12T08:27:04Z

It is a bit of a pet peeve on mine, having the community invest effort into enabling people to stay on old, insecure rubies, especially when upgrading Ruby (post 1.9) is relatively trivial. It's a disservice, if anything.

However, I think it's ultimately a question about what RuboCop's official standpoint should be. Will defer to @bbatsov to make the decision. 🙂

bbatsov · 2018-06-12T08:47:50Z

Btw, technically speaking 2.2 has reached it's EOL as well. :-)

I generally share @Drenmi's view on this, but I also realize that just keeping the parsing support around is not that big of a deal, so I'm fine with this.

I'll leave this open for a few days to see what other users & contributors think and I'll make the decision then. (plus I want to cut a bugfix release in the mean time)

Drenmi · 2018-06-12T08:49:47Z

Technically speaking 2.2 has reached it's EOL as well.

Yeah. It's a bit unclear. I think the page might not be updated regularly, so it still says "scheduled for 2018-03-31". 😅

bbatsov · 2018-06-12T09:14:37Z

Yeah, that's a good point as well. OK, let's focus on 2.1 only then. :-)

mikegee · 2018-06-12T18:40:04Z

lib/rubocop/config.rb

+    # 2.2 is the oldest officially supported Ruby version.
+    DEFAULT_RUBY_VERSION = 2.2
+    KNOWN_RUBIES = [2.2, 2.3, 2.4, 2.5].freeze
+    OBSOLETE_RUBIES = { 1.9 => '0.50', 2.0 => '0.50', 2.1 => 0.58 }.freeze


Maybe quote 0.58 too, for consistency?

koic · 2018-06-14T07:59:59Z

The following is preparation for announcement about EOL of Ruby 2.2.
ruby/www.ruby-lang.org#1806.

Apart from that, I understand that this PR focuses on Ruby 2.1 :-)

dgollahon · 2018-06-15T07:06:49Z

It is a bit of a pet peeve on mine, having the community invest effort into enabling people to stay on old, insecure rubies, especially when upgrading Ruby (post 1.9) is relatively trivial. It's a disservice, if anything.

FWIW, I agree completely. Especially since rubocop encourages community standards / best practices. Even if this causes a little bit of friction, that's also what a lot of rubocop cops are designed to do in order to help push you in the right direction.

bbatsov · 2018-06-15T17:30:42Z

Well, I've made a decision - let's just go with @Drenmi's original plan. If we manage to nudge more people to upgrade I think that's a good thing (tm) in the end of the day.

Drenmi · 2018-06-18T07:41:12Z

@bbatsov Comments addressed, rebased, and pushed.

koic · 2018-06-18T08:25:55Z

CHANGELOG.md

@@ -17,6 +17,9 @@
 * [#6006](https://github.com/bbatsov/rubocop/pull/6006): Remove `rake repl` task. ([@koic][])

 ## 0.57.2 (2018-06-12)
+### Changes
+
+* Drop support for MRI 2.1. ([@drenmi][])


This comment is a nitpick. I think that Changes section should be after Bug fixes section 😃

Feel free to reorder this. I don't have a strong preference on the subject, but ideally we should use a consistent ordering in the changelog.

My comment was wrong 💦
Since this item has not been released yet, it has moved to master (unreleased) section with the following commit.
5f70fae

Build is failing because of a missing space. Ideally let's not push to master. 😬

I'm sorry about that. I was not careful in pushing to master branch 😥

I confirmed that it was fixed by the following change.
a073d9a#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR18

As I changed changelog document only, I forgot to run bundle exec rake. The push to master branch should be confirmed more properly locally than open a PR will checked with CI.

I thought that push to master branch was preferable, as far as minor changes (e.g. fix typo, cosmetic change) were concerned, rather than being notified to the watching users by opening a PR. Of course the contents to be reviewed opens a PR. (So, I will open a PR as a basis.)

If pushing to master branch, I pay close attention so that builds can be more securely passed.

Don't worry, @koic. Mistakes happen to everyone. I'm fine with people fixing small things directly on master, I just want everyone to be very careful when doing this.

bbatsov · 2018-06-18T09:30:08Z

👍

Follow up of #5990 (comment). This commit added the address of pull request and fixed the position. Since it has not been released yet, it has moved to `master (unreleased)` section.

Ruby 2.1 will be dropped since next rubocop version rubocop/rubocop#5990

jonas054 · 2018-07-08T07:56:25Z

spec/rubocop/cop/lint/unused_method_argument_spec.rb

@@ -70,17 +70,6 @@ def some_method(foo, bar)
      end
    end

-    context 'when a required keyword argument is unused', ruby: 2.1 do


Here's a late comment. Keyword arguments without defaults were introduced in Ruby 2.1, so I think this example is for Ruby >= 2.1, rather than Ruby < 2.2, i.e., it should be kept.

Sure. I opened a PR #6104.

jonas054 · 2018-07-08T07:56:57Z

spec/rubocop/cop/metrics/parameter_lists_spec.rb

@@ -60,12 +60,5 @@ def meth(a, b, c, d: 1, e: 2)
        end
      RUBY
    end
-
-    it 'does not count keyword arguments without default values', ruby: 2.1 do


This example should probably be kept, too.

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

Fowllow up of rubocop#5990. Since RuboCop 0.58.0 drops support for MRI 2.1. This PR drops minimum target Ruby version from `Lint/UnneededRequireStatement`.

Fowllow up of #5990. Since RuboCop 0.58.0 drops support for MRI 2.1. This PR drops minimum target Ruby version from `Lint/UnneededRequireStatement`.

Follow up rubocop#10632 (comment). Reverts part of rubocop#5990 and rubocop#6101. Only the Ruby version (2.1) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.1 code analysis with `TargetRubyVersion: 2.1`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, rubocop#10640, and rubocop#10644.

Follow up #10632 (comment). Reverts part of #5990 and #6101. Only the Ruby version (2.1) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.1 code analysis with `TargetRubyVersion: 2.1`. It aims to solve essentially the same problem as #10626, #10632, #10640, and #10644.

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

Darhazer reviewed Jun 12, 2018

View reviewed changes

Drenmi force-pushed the maintenance/drop-mri-2-1 branch from 56bd7dd to 2b0be32 Compare June 12, 2018 07:27

mikegee reviewed Jun 12, 2018

View reviewed changes

Drop support for MRI 2.1

a220ed0

Drenmi force-pushed the maintenance/drop-mri-2-1 branch from 2b0be32 to a220ed0 Compare June 18, 2018 07:39

koic reviewed Jun 18, 2018

View reviewed changes

bbatsov merged commit a707c23 into rubocop:master Jun 18, 2018

Drenmi deleted the maintenance/drop-mri-2-1 branch June 18, 2018 09:42

koic added a commit that referenced this pull request Jun 18, 2018

Fix CHANGELOG.md

5f70fae

Follow up of #5990 (comment). This commit added the address of pull request and fixed the position. Since it has not been released yet, it has moved to `master (unreleased)` section.

sue445 added a commit to sue445/rubocop-itamae that referenced this pull request Jun 19, 2018

Drop Ruby 2.1 from CI

a9ee0df

Ruby 2.1 will be dropped since next rubocop version rubocop/rubocop#5990

sue445 mentioned this pull request Jun 19, 2018

Drop Ruby 2.1 from CI sue445/rubocop-itamae#9

Merged

jonas054 reviewed Jul 8, 2018

View reviewed changes

bquorning added a commit to rubocop/rubocop-rspec that referenced this pull request Jul 8, 2018

Upgrade RuboCop dependency to >= v0.58.0

4c08347

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

bquorning mentioned this pull request Jul 8, 2018

Upgrade RuboCop dependency to >= v0.58.0 rubocop/rubocop-rspec#664

Merged

5 tasks

koic mentioned this pull request Jul 14, 2018

Drop min target Ruby version from Lint/UnneededRequireStatement #6101

Merged

8 tasks

bbatsov pushed a commit that referenced this pull request Jul 15, 2018

Drop min target Ruby version from Lint/UnneededRequireStatement

582ee01

Fowllow up of #5990. Since RuboCop 0.58.0 drops support for MRI 2.1. This PR drops minimum target Ruby version from `Lint/UnneededRequireStatement`.

Darhazer mentioned this pull request Apr 17, 2019

Drop support for Ruby 2.2 and 2.3 #6945

Closed

bquorning mentioned this pull request Jun 7, 2020

Drop support for Ruby 2.4 #8112

Closed

koic mentioned this pull request May 23, 2022

Recover Ruby 2.1 code analysis using TargetRubyVersion: 2.1 #10662

Merged

8 tasks

pirj pushed a commit to rubocop/rubocop-capybara that referenced this pull request Dec 29, 2022

Upgrade RuboCop dependency to >= v0.58.0

501cf2a

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

ydah pushed a commit to rubocop/rubocop-factory_bot that referenced this pull request Apr 13, 2023

Upgrade RuboCop dependency to >= v0.58.0

75b7e62

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

ydah pushed a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024

Upgrade RuboCop dependency to >= v0.58.0

329eb1e

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

ydah pushed a commit to rubocop/rubocop-rspec_rails that referenced this pull request Mar 27, 2024

Upgrade RuboCop dependency to >= v0.58.0

1e152cf

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See rubocop/rubocop#5990

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for MRI 2.1 #5990

Drop support for MRI 2.1 #5990

Drenmi commented Jun 12, 2018 •

edited

Loading

Darhazer Jun 12, 2018

Drenmi Jun 12, 2018

pocke commented Jun 12, 2018

Drenmi commented Jun 12, 2018

bbatsov commented Jun 12, 2018

Drenmi commented Jun 12, 2018

bbatsov commented Jun 12, 2018

mikegee Jun 12, 2018

koic commented Jun 14, 2018

dgollahon commented Jun 15, 2018

bbatsov commented Jun 15, 2018

Drenmi commented Jun 18, 2018

koic Jun 18, 2018

bbatsov Jun 18, 2018

koic Jun 18, 2018

Drenmi Jun 18, 2018

koic Jun 19, 2018

bbatsov Jun 19, 2018

bbatsov commented Jun 18, 2018

jonas054 Jul 8, 2018

koic Jul 18, 2018

jonas054 Jul 8, 2018

Drop support for MRI 2.1 #5990

Drop support for MRI 2.1 #5990

Conversation

Drenmi commented Jun 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pocke commented Jun 12, 2018

Drenmi commented Jun 12, 2018

bbatsov commented Jun 12, 2018

Drenmi commented Jun 12, 2018

bbatsov commented Jun 12, 2018

Choose a reason for hiding this comment

koic commented Jun 14, 2018

dgollahon commented Jun 15, 2018

bbatsov commented Jun 15, 2018

Drenmi commented Jun 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bbatsov commented Jun 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Drenmi commented Jun 12, 2018 •

edited

Loading