Ruby 3.0's Regexp and Range literals will be frozen #9282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Dec 23, 2020
This PR makes `Style/RedundantFreeze` and `Style/MutableConstant` cops aware of frozen regexp and range literals when using Ruby 3.0. - https://bugs.ruby-lang.org/issues/15504 - https://bugs.ruby-lang.org/issues/16377 ```console % ruby -ve 'p(/regexp/.frozen?); p (0..42).frozen?' ruby 3.0.0dev (2020-12-23T03:25:41Z master 02233ed024) [x86_64-darwin19] true true ``` ```console % ruby -ve 'p(/regexp/.frozen?); p (0..42).frozen?' ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19] false false ```
koic
force-pushed
the
frozen_ragexp_and_range_literals
branch
from
90ca872 to
c7a1a65
Compare
|
Thanks for the reviews! I updated this PR. |
|
Thanks! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Style/RedundantFreezeandStyle/MutableConstantcops aware of frozen regexp and range literals when using Ruby 3.0.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.