Rails/SaveBang: parens are enough to fool it

[akimd]

Hi guys!

Expected behavior

Here, save's return value is checked, there should not be complains about it.

$ cat /tmp/save.rb
  def foo
    @user = User.find(params[:id])
    if(@user.save)
      puts 'ok'
    else
      puts 'ko'
    end
  end

Actual behavior

$ bundle exec rubocop --only Rails/SaveBang /tmp/save.rb
Inspecting 1 file
Offenses:

/tmp/save.rb:3:14: C: [Correctable] Rails/SaveBang: Use save! instead of save if the return value is not checked.
    if(@user.save)
             ^^^^

1 file inspected, 1 offense detected, 1 offense autocorrectable

Steps to reproduce the problem

The problem is the parens. I wholeheartedly agree that they are not just superfluous, they are undesirable. Yet this piece of code is valid, and the parens should be ignored.

RuboCop version

$ bundle exec rubocop -V
1.56.3 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 3.2.2) [arm64-darwin22]
  - rubocop-performance 1.19.1
  - rubocop-rails 2.21.2
  - rubocop-thread_safety 0.5.1

[akimd]

Thanks a lot for this!