-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Rails/LinkToBlank, because it is outdated #1294
Comments
3 years doesn't seem that long ago, an update to the cops documentation pointing this out seems more appropriate. |
I don't think we should be encouraging developers to litter their code with |
There no doubt that users with old browser have a plethora of issues and really should update. For me there are still a good chunk that don't do that for one reason or another. I can't tell what the consequences would be for those if this is disabled. If it does anything at all I'd prefer to keep it. That's just my personal opinion, I don't know when a good point would be to disable this. Maybe now, maybe a year ago already, or just 5 years in the future. 🤷 |
This is only a vulnerability in over three years old browsers.
rubocop-rails/config/default.yml
Line 653 in 202d8c1
From https://mathiasbynens.github.io/rel-noopener/
So the cop should be disabled.
The text was updated successfully, but these errors were encountered: