False positive on Rails/ActionControllerFlashBeforeRender

[jcoyne]

app/controllers/quick_reports_controller.rb:5:7: C: [Correctable] Rails/ActionControllerFlashBeforeRender: Use flash.now before render.
      flash[:success] = t("blacklight.feedback_form.success")
      ^^^^^

On this code:

      flash[:success] = t("blacklight.feedback_form.success")
      respond_to do |format|
        format.json do
          render json: flash
        end
        format.html do
          redirect_to params[:url]
        end
      end

If you do flash.now then the flash is lost on the redirect_to branch.

Using: rubocop-rails-2.17.2

[koic]

This issue is similar to #843 and resolved by #844. False negatives may remain, but this unexpected new false positive is resolved. Please wait for the bug fix release.