Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilePath cop conflicts with new base RuboCop's Rails/FilePath cop #301

Closed
mvz opened this issue Jan 17, 2017 · 3 comments
Closed

FilePath cop conflicts with new base RuboCop's Rails/FilePath cop #301

mvz opened this issue Jan 17, 2017 · 3 comments

Comments

@mvz
Copy link
Contributor

mvz commented Jan 17, 2017

I have configuration for RSpec/FilePath in my .rubocop.yml file, and RuboCop 0.47.0 complains about it:

[..]/reek/.rubocop.yml: RSpec/FilePath has the wrong namespace - should be Rails

Also, this causes RSpec/FilePath not to be configured 🙁.
@backus
Copy link
Collaborator

backus commented Jan 17, 2017

Yeah I thought I fixed this in rubocop before they released this new cop but unfortunately I neglected to help them fix their config loading. This is a dupe of #299 which I fixed with rubocop/rubocop#3914. If you want to request a patch release of rubocop proper to fix this I would support that 😉

@backus backus closed this as completed Jan 17, 2017
@backus
Copy link
Collaborator

backus commented Jan 17, 2017

Oh and the workaround should be to depend on RuboCop master. Can you actually confirm for me that this fixes your problem?

@mvz
Copy link
Contributor Author

mvz commented Jan 17, 2017

Yes, that fixes my problem, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvz @backus