Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe: Rubocop silently accepts complete garbage as configuration #1428

Closed
e2 opened this issue Nov 4, 2014 · 5 comments
Closed

Severe: Rubocop silently accepts complete garbage as configuration #1428

e2 opened this issue Nov 4, 2014 · 5 comments

Comments

@e2
Copy link
Contributor

e2 commented Nov 4, 2014

Rubocop shows no error, even if the config file is complete garbage (anything that's a valid UTF-8 stream at least).

How to reproduce:

  1. echo '"' > bad.yml
  2. rubocop -c bad.yml

Expected: e.g. "Psych::SyntaxError: (): found unexpected end of stream"
Actual: no errors

Introduced by commit: 57aadf2

This would ultimately solve the problem (somewhat related):
#1151

So, while Rubocop is extremely fussy about Ruby code, Rubocop's config files have a "get out of jail" card.

Oh the irony :D

(I marked this as severe because of how much time people can waste reproducing and reporting issues)

@bbatsov
Copy link
Collaborator

bbatsov commented Jan 25, 2015

I seem to recall us fixing this recently, but I can't find the related PR.

@bquorning
Copy link
Contributor

I think it might be fixed by #1504

@bquorning
Copy link
Contributor

Or rather #1511.

@bbatsov
Copy link
Collaborator

bbatsov commented Jan 25, 2015

Thanks, @bquorning!

@bbatsov bbatsov closed this as completed Jan 25, 2015
@e2
Copy link
Contributor Author

e2 commented Jan 25, 2015

😍 Thanks, @bquorning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants