Crash on enforce_avialable_locales without locale :en

[thedarkside]

My rails app is configured this way:

config.i18n.available_locales = [:de]
config.i18n.default_locale = :de
config.i18n.fallbacks = true

The enforce_available_locales is set to true by default.

When hitting the grape api with an invalid request, grape sets the locale to the FALLBACK_LOCALE which is :en and crashes due to enforce_available_locales being true like so:

I18n::InvalidLocale (:en is not a valid locale):
  
i18n (1.0.1) lib/i18n.rb:311:in `enforce_available_locales!'
i18n (1.0.1) lib/i18n.rb:179:in `translate'
grape (1.1.0) lib/grape/exceptions/base.rb:77:in `translate'
grape (1.1.0) lib/grape/exceptions/base.rb:65:in `translate_message'
grape (1.1.0) lib/grape/exceptions/validation.rb:13:in `initialize'
grape (1.1.0) lib/grape/validations/validators/presence.rb:6:in `exception'
grape (1.1.0) lib/grape/validations/validators/presence.rb:6:in `raise'

In my opinion grape should check if :en is available and if not then just return the key in the error response instead of crashing miserably

[dblock]

You're probably right, try turning it into a spec next?

[Morred]

Hope it's ok to jump in here as there hasn't been a reply from the original reporter in a while.
I made a PR here #1796, the first commit confirms that indeed an exception is raised if available locales are enforced but don't contain :en. Second commit has a fix that checks if the available locales are enforced and fallback locale is available and if not, returns the translation string instead of crashing.

[Morred]

@dblock Fixed via #1796, let's close?