Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with CustomValidator if it's name doesn't end with "_validator" #2336

Closed
ericproulx opened this issue Jun 10, 2023 · 0 comments · Fixed by #2337
Closed

Issue with CustomValidator if it's name doesn't end with "_validator" #2336

ericproulx opened this issue Jun 10, 2023 · 0 comments · Fixed by #2337
Labels
confirmed bug

Comments

@ericproulx
Copy link
Contributor

I found a issue while registering a custom validator in our app. The delete_suffix!! will return nil if no change was made. We need to remove the !.

I'll open a PR to fix it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix custom validator not ending with _validator ericproulx/grape
1 participant
@ericproulx