Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hashie required version to >= 2.0.2 #355

Merged
merged 2 commits into from
Mar 1, 2013

Conversation

reset
Copy link
Contributor

@reset reset commented Feb 28, 2013

Hashie has seen some improvements. Do you think we could bump the required version?

it's important to lock to 2.0.2

@dblock
Copy link
Member

dblock commented Feb 28, 2013

Why would we want to force a higher version while Grape works with everything? What's in 2.x that's a must have? Maybe just removing a version in Grape's gemspec or making it >= 1.2?

Either way, please also update CHANGELOG. Thanks.

@reset
Copy link
Contributor Author

reset commented Mar 1, 2013

@dblock making it >= 1.2 would work just fine for me as well and probably makes more sense. I have a requirement on 2.0.2 in one of my libraries which is causing an application that leverages Grape to die since it is locked at ~> 1.2.

@dblock dblock merged commit a003eac into ruby-grape:master Mar 1, 2013
@dblock
Copy link
Member

dblock commented Mar 1, 2013

Merged, thank you.

@reset
Copy link
Contributor Author

reset commented Mar 1, 2013

It would make my day amazing if you could bump the version to 0.3.3 and release this (even though it's really small!). Appreciate it man!

@reset reset deleted the relax-hashie-req branch March 1, 2013 01:25
@dblock
Copy link
Member

dblock commented Mar 1, 2013

Released 0.3.2.

@reset
Copy link
Contributor Author

reset commented Mar 1, 2013

❤️ seriously made my night easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants