Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: toplevel constant DateTime referenced by Virtus::Attribute::DateTime #921

Closed
stgeneral opened this issue Feb 11, 2015 · 3 comments

Comments

@stgeneral
Copy link

Seems that recent pull request #916 introduces the warning:

.rvm/gems/ruby-2.1.2/bundler/gems/grape-5e48701fbbdb/lib/grape/validations/validators/coerce.rb:35: warning: toplevel constant DateTime referenced by Virtus::Attribute::DateTime
@dblock dblock added the bug? label Feb 11, 2015
@dm1try
Copy link
Member

dm1try commented Feb 13, 2015

This is right. We have virtus >= 1.0.0 dependency.
There is no more Virtus::Attribute::DateTime in virtus, see -https://github.com/solnic/virtus/blob/v1.0.0/Changelog.md

[BREAKING CHANGE] Integrated with axiom-types, most of the attribute sub-classes are gone (solnic)

so Ruby constant lookup, thanks for the working code 😄

@dm1try dm1try added confirmed bug and removed bug? labels Feb 13, 2015
@dm1try
Copy link
Member

dm1try commented Feb 13, 2015

@u2 could you take a look?

@u2
Copy link
Contributor

u2 commented Feb 13, 2015

#925
Thank you.It's my mistake.

@dm1try dm1try closed this as completed Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants