Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passkey keyword parameter to PasskeyAuthenticatable.after_passkey_authentication #14

Closed
tcannonfodder opened this issue Jun 23, 2023 · 0 comments · Fixed by #26
Closed
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tcannonfodder
Copy link
Contributor

tcannonfodder commented Jun 23, 2023

To make the callback more useful, it should include the passkey that was used to authenticate.

This would make it easier to perform actions like:

  • Notifying the user that a new authentication occurred (and which passkey was used)
  • Updating some app-specific data related to the passkey

So the new method signature should be:

def after_passkey_authentication(passkey:)
...
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant