remove enum NONE

Author: Steve Newell

lib/protobuf/rpc/stat.rb

@@ -13,7 +13,6 @@ class Stat
       MODES = [:SERVER, :CLIENT].freeze
 
       ERROR_TRANSLATIONS = {
-        ::Protobuf::Socketrpc::ErrorReason::NONE => "OK",
         ::Protobuf::Socketrpc::ErrorReason::BAD_REQUEST_DATA => "BAD_REQUEST_DATA",
         ::Protobuf::Socketrpc::ErrorReason::BAD_REQUEST_PROTO => "BAD_REQUEST_PROTO",
         ::Protobuf::Socketrpc::ErrorReason::SERVICE_NOT_FOUND => "SERVICE_NOT_FOUND",
@@ -30,7 +29,6 @@ def initialize(mode = :SERVER)
         @mode = mode
         @request_size = 0
         @response_size = 0
-        @status = ::Protobuf::Socketrpc::ErrorReason::NONE  # default to NONE and only set if error occurs
         start
       end
 
@@ -95,6 +93,8 @@ def client?
       end
 
       def status_string
+        return "OK" if status.nil?
+
         ERROR_TRANSLATIONS.fetch(status, "UNKNOWN_ERROR")
       end
 

proto/rpc.proto

@@ -66,5 +66,4 @@ enum ErrorReason
   BAD_RESPONSE_PROTO = 7;                       // Server returned a bad response proto
   UNKNOWN_HOST = 8;                             // Could not find supplied host
   IO_ERROR = 9;                                 // I/O error while communicating with server
-  NONE = 10000;                                // No error.  Typically not used.  This is a placeholder to remind us not to use this value.
 }