Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Durable spec wrong and useless #52

Closed
gkellogg opened this issue Feb 9, 2016 · 0 comments
Closed

Durable spec wrong and useless #52

gkellogg opened this issue Feb 9, 2016 · 0 comments
Labels

Comments

@gkellogg
Copy link
Member

gkellogg commented Feb 9, 2016

RDF::Durable spec "is_expected.to save contents between instantiations" can't work if TRIPLES_FILE contains BNodes, as it will insert new statements where those BNodes are present. Secondly, it is not really testing durability; this would require something else where the repo was updated, and a new repo using the same endpoint was created which should now be the same. This probably relies on the uri argument identifying the endpoint, and/or a callout to do this. It might be something like the following:

if subject.durable?
  subject.empty!
  instance = subject.class.new(uri: subject.uri, subject.options)
  expect(subject).to be_empty
end
@gkellogg gkellogg added the bug label Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant