Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable should have a de-dup mechanism #263

Closed
gkellogg opened this issue Jan 17, 2016 · 1 comment
Closed

Mutable should have a de-dup mechanism #263

gkellogg opened this issue Jan 17, 2016 · 1 comment
Assignees
@gkellogg

Comments

@gkellogg
Copy link
Member

Because multiple BNodes which are distinct but share the same identifier may be introduced into a Mutable, there should be a mechanism (similar to that for Writers in #262) to modify the identifier of nodes that are shared to avoid confusion.
@gkellogg gkellogg self-assigned this Jan 17, 2016
@no-reply no-reply mentioned this issue Jan 17, 2016
Closed
@gkellogg
Copy link
Member Author

gkellogg commented Feb 8, 2016

Probably best to do in Enumerable and yield a new enumerable which has de-dupped nodes. However, the footprint of this is pretty large, and it is probably not useful, given de-dupping in Writer#write_statement.

@gkellogg gkellogg closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkellogg gkellogg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkellogg