Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp/.keep packaged in gem #122

Closed
pvalena opened this issue May 13, 2019 · 7 comments
Closed

tmp/.keep packaged in gem #122

pvalena opened this issue May 13, 2019 · 7 comments

Comments

@pvalena
Copy link

pvalena commented May 13, 2019

Hello, could you not package the empty tmp/.keep file in rubygems.org gem?

On Fedora we try to avoid unnecessary empty files packaged on a distribution.

@yuki24
Copy link
Member

yuki24 commented May 14, 2019

I can totally remove that from distributed packages starting the next release (releases are immutable and can't be updated).

Just out of curiosity, what are the reasons why you are following that rule?

@pvalena
Copy link
Author

pvalena commented May 14, 2019

I can totally remove that from distributed packages starting the next release (releases are immutable and can't be updated).

Thanks.

Just out of curiosity, what are the reasons why you are following that rule?

From what I can tell, it's just a rpmlint guideline to keep files on a system relevant. If there was some important reason, it was not documented.
https://fedoraproject.org/wiki/Common_Rpmlint_issues#zero-length

@pvalena
Copy link
Author

pvalena commented May 14, 2019

One additional question: is tmp/ folder needed for gem runtime? I doubt it as it is not writable.

I have found reference to it only in one test.

@yuki24
Copy link
Member

yuki24 commented Jun 3, 2019

One additional question: is tmp/ folder needed for gem runtime?

No, it is only used in test and that test can totally look at other file that permanently exists in the repo. Maybe did_you_mean.gemspec is a good one.

@yuki24
Copy link
Member

yuki24 commented Jun 3, 2019

fixed by a62833d

@yuki24 yuki24 closed this as completed Jun 3, 2019
@pvalena
Copy link
Author

pvalena commented Jun 3, 2019

Thanks!

@yuki24
Copy link
Member

yuki24 commented Sep 29, 2019

released as v1.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants