Skip to content

feat(paranoia): add replacements for untyped #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

casaper
Copy link
Contributor

@casaper casaper commented May 19, 2025

  • type for optional options of ActiveRecord::Base.acts_as_paranoid
  • fixed wrong or missing response types added to ActiveRecord::Base by paranoia gem
  • Typing of more methods in paranoia gem models
  • Included the class methods into the module Paranoia::Query with ClassMethods[untyped, untyped] to prevent my changes braking existing usages of this sig
  • included instance methods into Paranoia with InstanceMethods[untyped] to prevent braking current sig usages
  • Added some more tests

Copy link

@casaper Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

paranoia

You changed RBS files for an existing gem.
This gem does not have reviewers. So you can merge this PR immediately if the CI passes.
We recommend you add yourself to the reviewers for this gem.

@casaper casaper force-pushed the feat/paranoia_replace_untyped branch 2 times, most recently from 3423701 to d3e27c9 Compare May 19, 2025 15:55
@casaper casaper force-pushed the feat/paranoia_replace_untyped branch from d3e27c9 to 1612b9f Compare May 19, 2025 15:58
@casaper
Copy link
Contributor Author

casaper commented May 19, 2025

/merge

@github-actions github-actions bot merged commit b3277de into ruby:main May 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant