Skip to content

Commit 1136bd8

Browse files
committed
🔊 Warn about deprecated responses usage
This was extracted from #93 and split into a separate PR. This allows us to prepare dependent projects for the new behavior before their logs are flooded with deprecation warnings.
1 parent 80c8964 commit 1136bd8

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/net/imap.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2501,7 +2501,7 @@ def responses(type = nil)
25012501
elsif type
25022502
raise ArgumentError, "Pass a block or use #clear_responses"
25032503
else
2504-
# warn("DEPRECATED: pass a block or use #clear_responses", uplevel: 1)
2504+
warn("DEPRECATED: pass a block or use #clear_responses", uplevel: 1)
25052505
@responses
25062506
end
25072507
end

test/net/imap/test_imap.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1104,10 +1104,10 @@ def test_responses
11041104
assert_equal(1, imap.responses("RECENT", &:last))
11051105
assert_raise(ArgumentError) do imap.responses("UIDNEXT") end
11061106
# Deprecated style, without a block:
1107-
# assert_warn(/Pass a block.*or.*clear_responses/i) do
1108-
# assert_equal(%i[Answered Flagged Deleted Seen Draft],
1109-
# imap.responses["FLAGS"]&.last)
1110-
# end
1107+
assert_warn(/Pass a block.*or.*clear_responses/i) do
1108+
assert_equal(%i[Answered Flagged Deleted Seen Draft],
1109+
imap.responses["FLAGS"]&.last)
1110+
end
11111111
end
11121112
end
11131113

0 commit comments

Comments
 (0)