Skip to content

Commit 3410acd

Browse files
committed
🔊 Warn about deprecated responses usage
This was extracted from #93 and split into a separate PR. This allows us to prepare dependent projects for the new behavior before their logs are flooded with deprecation warnings.
1 parent 4848153 commit 3410acd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/net/imap.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2307,7 +2307,7 @@ def responses(type = nil)
23072307
elsif type
23082308
raise ArgumentError, "Pass a block or use #clear_responses"
23092309
else
2310-
# warn("DEPRECATED: pass a block or use #clear_responses", uplevel: 1)
2310+
warn("DEPRECATED: pass a block or use #clear_responses", uplevel: 1)
23112311
@responses
23122312
end
23132313
end

test/net/imap/test_imap.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,10 +1085,10 @@ def test_responses
10851085
assert_equal(1, imap.responses("RECENT", &:last))
10861086
assert_raise(ArgumentError) do imap.responses("UIDNEXT") end
10871087
# Deprecated style, without a block:
1088-
# assert_warn(/Pass a block.*or.*clear_responses/i) do
1089-
# assert_equal(%i[Answered Flagged Deleted Seen Draft],
1090-
# imap.responses["FLAGS"]&.last)
1091-
# end
1088+
assert_warn(/Pass a block.*or.*clear_responses/i) do
1089+
assert_equal(%i[Answered Flagged Deleted Seen Draft],
1090+
imap.responses["FLAGS"]&.last)
1091+
end
10921092
end
10931093
end
10941094

0 commit comments

Comments
 (0)