Merge pull request #19 from casperisfine/fix-read-adapter-leak

Undo BufferedIO#rbuf_consume_all_shareable! optimization

Author: hsbt

lib/net/protocol.rb

@@ -157,7 +157,7 @@ def read(len, dest = ''.b, ignore_eof = false)
       read_bytes = 0
       begin
         while read_bytes + rbuf_size < len
-          if s = rbuf_consume_all_shareable!
+          if s = rbuf_consume_all
             read_bytes += s.bytesize
             dest << s
           end
@@ -178,7 +178,7 @@ def read_all(dest = ''.b)
       read_bytes = 0
       begin
         while true
-          if s = rbuf_consume_all_shareable!
+          if s = rbuf_consume_all
             read_bytes += s.bytesize
             dest << s
           end
@@ -250,18 +250,8 @@ def rbuf_size
       @rbuf.bytesize - @rbuf_offset
     end
 
-    # Warning: this method may share the buffer to avoid
-    # copying. The caller must no longer use the returned
-    # string once rbuf_fill has been called again
-    def rbuf_consume_all_shareable!
-      @rbuf_empty = true
-      buf = if @rbuf_offset == 0
-        @rbuf
-      else
-        @rbuf.byteslice(@rbuf_offset..-1)
-      end
-      @rbuf_offset = @rbuf.bytesize
-      buf
+    def rbuf_consume_all
+      rbuf_consume if rbuf_size > 0
     end
 
     def rbuf_consume(len = nil)