Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert OpenSSL::Config to using OpenSSL API #340

Closed
rhenium opened this issue Feb 17, 2020 · 0 comments · Fixed by #342
Closed

Revert OpenSSL::Config to using OpenSSL API #340

rhenium opened this issue Feb 17, 2020 · 0 comments · Fixed by #342

Comments

@rhenium
Copy link
Member

rhenium commented Feb 17, 2020

As discussed in #208, we should not implement the parser ourselves but just use the appropriate OpenSSL APIs.

One incompatible change needed for this is that we lose the ability to modify the config. (I doubt if there has been any actual use-case for this feature, however.)

#322 deprecated these two methods and calling them with (to be released) v2.2.0 will emit warning:

  • OpenSSL::Config#add_value
  • OpenSSL::Config#[]=
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant