Skip to content

Commit 49a3125

Browse files
Improve wording of unmet dependencies warning
`trying to manually editing` doesn't seem quite grammatically correct. We could change it to `trying to manually edit` (is that a split infinitive?), but I don't think `trying to` adds much here so I've removed it instead so `editing` is the verb. For the list of dependencies, the wording before this commit seemed to reverse the dependency. "B, depended on A" sounds like B depends on A (or did in the past but doesn't anymore?), but that's not correct. I think there's a missing word: "B, depended on by A", but I find "B, dependency of A" a bit nicer.
1 parent c31c575 commit 49a3125

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

bundler/lib/bundler/installer/parallel_installer.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,12 @@ def check_for_unmet_dependencies
110110

111111
warning = []
112112
warning << "Your lockfile doesn't include a valid resolution."
113-
warning << "You can fix this by regenerating your lockfile or trying to manually editing the bad locked gems to a version that satisfies all dependencies."
113+
warning << "You can fix this by regenerating your lockfile or manually editing the bad locked gems to a version that satisfies all dependencies."
114114
warning << "The unmet dependencies are:"
115115

116116
unmet_dependencies.each do |spec, unmet_spec_dependencies|
117117
unmet_spec_dependencies.each do |unmet_spec_dependency|
118-
warning << "* #{unmet_spec_dependency}, depended upon #{spec.full_name}, unsatisfied by #{@specs.find {|s| s.name == unmet_spec_dependency.name && !unmet_spec_dependency.matches_spec?(s.spec) }.full_name}"
118+
warning << "* #{unmet_spec_dependency}, dependency of #{spec.full_name}, unsatisfied by #{@specs.find {|s| s.name == unmet_spec_dependency.name && !unmet_spec_dependency.matches_spec?(s.spec) }.full_name}"
119119
end
120120
end
121121

bundler/spec/bundler/installer/parallel_installer_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
it "prints a warning" do
2323
expect(Bundler.ui).to receive(:warn).with(<<-W.strip)
2424
Your lockfile doesn't include a valid resolution.
25-
You can fix this by regenerating your lockfile or trying to manually editing the bad locked gems to a version that satisfies all dependencies.
25+
You can fix this by regenerating your lockfile or manually editing the bad locked gems to a version that satisfies all dependencies.
2626
The unmet dependencies are:
27-
* diff-lcs (< 1.4), depended upon cucumber-4.1.0, unsatisfied by diff-lcs-1.4.4
27+
* diff-lcs (< 1.4), dependency of cucumber-4.1.0, unsatisfied by diff-lcs-1.4.4
2828
W
2929
subject.check_for_unmet_dependencies
3030
end

0 commit comments

Comments
 (0)