Skip to content

Commit 3517743

Browse files
committed
Add test for trailing blank lines
Check for blank lines at end of file.
1 parent 24b2b80 commit 3517743

File tree

5 files changed

+27
-0
lines changed

5 files changed

+27
-0
lines changed

lib/linter.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ def check
6464
errors[doc] << "missing or invalid lang variable" if doc.lang_invalid?
6565
errors[doc] << "lang variable not matching file location" if doc.lang_not_matching_filename?
6666
errors[doc] << "no newline at end of file" if doc.no_newline_at_eof?
67+
errors[doc] << "blank line(s) at end of file" if doc.blank_line_at_eof?
6768
errors[doc] << "wrong line breaks (CR/LF)" if doc.crlf_line_breaks?
6869

6970
unless WHITESPACE_EXCLUSIONS.include?(doc.filename)

lib/linter/document.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,10 @@ def no_newline_at_eof?
9191
!content.end_with?("\n")
9292
end
9393

94+
def blank_line_at_eof?
95+
content.end_with?("\n\n")
96+
end
97+
9498
def trailing_whitespace?
9599
content.match?(/ $/)
96100
end
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
layout: page
3+
title: "Page"
4+
lang: en
5+
---
6+
7+
Content
8+
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
layout: page
3+
title: "Page"
4+
lang: en
5+
---
6+
7+
Content
8+
9+
10+

test/output_errors.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ en/09_lang_variable_wrong.md
2020
en/10_multiple_errors.md
2121
missing or invalid lang variable
2222
trailing whitespace
23+
en/11_blank_line_at_eof.md
24+
blank line(s) at end of file
25+
en/12_blank_lines_at_eof.md
26+
blank line(s) at end of file
2327
en/_posts/2000-01-01-old-lang-variable-nil.md
2428
missing or invalid lang variable
2529
en/_posts/2000-01-02-old-translator-variable-wrong-type.md

0 commit comments

Comments
 (0)