-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict signature input by time #4
Comments
Just while I'm glancing at this and thinking through things a little:
|
I think automatic check-out would run afoul of the grant requirements since we can't automatically collect a check-out signature. Maybe we can send an email to the volunteer asking them to please sign out in addition to the Hotel California rule. |
Is this still a desired feature? If so, it sounds like this is what we need–let me know if I'm off at all:
Anything else? |
Those are definitely desired features, especially the last one. |
When the volunteers are selecting a time, they get a widget to select the time with. This widget is from lolliclock, and it looks like an actual clock, not a list. From what I've seen looking at the documentation and code, there isn't a built in way to make invalid options look and behave disabled. I think we could either use a different time picker that uses lists, or we could write js and css to make times outside of the admin set range look and behave disabled. For that first option, we could use something like the one from pickadate. I think different fields would be needed for hours and minutes, unless there's a good interval to show for the available times that doesn't make the list too long. For the second option, we could use some css to make hours & minutes outside of this range look disabled (transparent/lighter), and then write some js to ignore clicks/touches outside of the approved range. Is there a preference for one of these options over the other, or another suggestion? |
I think this issue requires server side validation, but these are good points, we can improve the UX by also giving indications in the UI of what inputs will pass validation. @glazomaniac is there an interval that makes sense to use? Do we expect volunteers to give exact (down to the minute) times, or do we expect them to round to (for example) the nearest half-hour? The second link in @crawfoal 's comment has a demo of a time picker configured for half-hours. @jenpen might have some ideas on how to work with the current pickers. |
I'm not sure what the grant requires (and apparently, no one is?). Specificity is probably useful, but if intervals are easier for y'all, I'd go with 15 minute ones if at all possible. Thanks for all y'all's work on this! |
I can get started on this if the following tasks sounds good to everyone:
I believe that the email reminder has already been implemented. |
@crawfoal sounds great! That breakdown of the tasks makes sense to me. I'd suggest doing each task in a separate commit if possible, or even separate PRs. Since there's default behavior, it should be possible get the validation and picker working before adding the admin page, if you want. That approach might require some rework at the end, but I'd guess the user-defined intervals will add complexity to the other tasks.
Yes, in #125. |
The org would like the ability to restrict volunteer sign-in and sign-out to specified time ranges.
The text was updated successfully, but these errors were encountered: