Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N - find places where we have not used I18N and add copy to en.yml #737

Closed
kasugaijin opened this issue May 22, 2024 · 9 comments
Closed
Labels
good first issue Good for newcomers

Comments

@kasugaijin
Copy link
Collaborator

kasugaijin commented May 22, 2024

We started off well adding text displayed in the UI (view copy, alert messages, and active record error messages) in the I18n en.yml file, but then we got a bit forgetful.

This task is to look through the application and find cases where we should move text from a view to en.yml, a controller (e.g., alert messages), and also add copy in en.yml for active record validation error messages.

I am not specifying a set amount of work for this task as I don't know how many places this occurs. If you prefer, you can scope the work and report back, or just start making the changes and make a PR resource by resource.

@kasugaijin kasugaijin added good first issue Good for newcomers Ready Make a comment to get assigned. labels May 22, 2024
@kasugaijin kasugaijin changed the title I18N - find places where we have not used I18N and add to en.yml I18N - find places where we have not used I18N and add copy to en.yml May 22, 2024
@wandergithub
Copy link
Contributor

Can I work on this issue?

@kasugaijin kasugaijin added Assigned and removed Ready Make a comment to get assigned. labels May 28, 2024
@jmilljr24
Copy link
Collaborator

@wandergithub just an fyi, in #738 which will be merged soon I added a method which you can use for translating enum's if you get to those in this issue. Let me know if you have any questions about it.

@wandergithub
Copy link
Contributor

@kasugaijin Hi, after working and investigating this issue I've noticed that updating translations in big chunks has led to some translations being missing due to managing too much of them.

I don't know what you guys would like me to do with #791 or if you want me to continue with the views to manage to close this issue. But I've been thinking it would be better if the translations are added while working with code and changes related to them in isolated ways. Like a gradual work/progress on upcoming PRs. Now it should be easier with the rules while we reinforce the use of I18n in the reviews. I can help with that too.

@kasugaijin
Copy link
Collaborator Author

@wandergithub I'd say do as much as you are comfortable doing in the PR, then we can try address the rest in related work. The only issue with leaving it to other work is that it will probably be forgotten about, and there may be areas that do not get any focus for a while, if at all. But, that said, I don't want this to become uncomfortably large for you either.

@wandergithub
Copy link
Contributor

I will wrap up my contributions to the translations with this last PR. Moving on to addressing other topics.

Copy link

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link

Automatically unassigned after 7 days of inactivity.

@Meri-MG
Copy link
Contributor

Meri-MG commented Oct 7, 2024

Hello, @kasugaijin, can I start working on this issue?

@kasugaijin
Copy link
Collaborator Author

@Meri-MG hey this issue got split into two other issues that were picked up. I should close this issue. Sorry about that. Is there another ‘ready’ issue you are interested in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants