Address skipped tests

[cielf]

Summary

We have a number of skipped tests (10 at time of writing), some of which have been skipped for months. Let's figure out what's going on with each and address it.

Why?

Technical debt. Some things that should be tested aren't being tested, probably. Increased robustness

Details

For each currently skipped test,

• Investigate why it might be skipped
• If it shouldn't (even!) exist, delete it
• If it should, figure out why we are skipping it and either address the problem, or write up an issue for the problem

Criteria for completion

• For each currently skipped test, either:
  -- delete it -- but add an explanation as to why to this issue, or
  -- fix the issue that is making it be skipped now, or
  -- write up the issue that is making it be skipped now.

[Haradd]

I can take this one 🙂

@cielf, how exactly do you search for skipped tests? I found only 6 of them, I'm not sure if that's a full list 🤔

[cielf]

Hi @Haradd -- I'm pretty sure I got that number by running rspec and observing what tests were skipped. I just ran it again on a fairly recent branch and got 9 ignored. Some of the tests are skipped by other means -- I'm seeing references to xdescribe and xit.

[Haradd]

alright, that makes sense 🙂 thank you!

[github-actions]

This issue has been inactive for 261 hours (10.88 days) and will be automatically unassigned after 99 more hours (4.13 days).

[Haradd]

I'm still on it

[Haradd]

Ready for review: #3606