Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of announcements #3582

Closed
2 tasks
cielf opened this issue May 14, 2023 · 3 comments · Fixed by #3605
Closed
2 tasks

Order of announcements #3582

cielf opened this issue May 14, 2023 · 3 comments · Fixed by #3605
Labels
Good First Issue Suitable for users that are newer or less experienced Help Wanted Groomed + open to all!

Comments

@cielf
Copy link
Collaborator

cielf commented May 14, 2023

#Summary
The announcments in the bank dashboard are currently showing with the ones with an expiry date first, then the ones without. They should show in reverse creation date order.

Details

Example

This is what it currently looks like (on prod)
Image

In this case, the order should be May 7, April 30, April 16

Recreation

  • as superuser, create 2 announcments - one with an expiry date, then one without.
  • sign in as a bank
  • The one without an expiry date (which was created most recently) should be on top.

Criteria for completion

  • functionality as above
  • test to support
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label May 14, 2023
@scooter-dangle scooter-dangle added the Help Wanted Groomed + open to all! label May 14, 2023
@jadekstewart3
Copy link
Contributor

May I please take this one?

@jadekstewart3
Copy link
Contributor

For clairification: you would like the announcements without an expiry date shown first and all in descending created at order?

@cielf
Copy link
Collaborator Author

cielf commented May 18, 2023

I want them displayed in reverse creation date order whether or not they have an expiry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced Help Wanted Groomed + open to all!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants