Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Alignment -- on all things #4672

Open
1 task
cielf opened this issue Sep 29, 2024 · 5 comments
Open
1 task

Header Alignment -- on all things #4672

cielf opened this issue Sep 29, 2024 · 5 comments

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 29, 2024

Summary

Match header alignment to the contents on all tables.

Why?

It'll look better, and be slightly easier to read if the header is above the content.

Details

This is a look at each screen in the system and make it match kind of job. A bit tedious, Especially since most of them are alright.

For example: One screen where we know the alignment is off is the "All Purchases" screen (sign in as org_admin@example.com, "Purchases", "All Purchases". In this case the headers Quantity of Items, Variety of Items, Amount spent, FMV and Purchased Date should all be right-justified.

Image

We are certainly open to multiple PRs on this if you can do the work on a couple of screens - but please record what screens you have looked at here, so we don't get duplication of effort.

Criteria for completion

  • headers align with content
@inane-pixel
Copy link
Contributor

I can do this one!

@cielf
Copy link
Collaborator Author

cielf commented Sep 30, 2024

Assigning it to you! Please include screenshots in your PR. Thanks!

@inane-pixel
Copy link
Contributor

#4715

@cielf
Copy link
Collaborator Author

cielf commented Oct 23, 2024

The item and purchase indices have been addressed, but there are still lots of minor alignment adjustments up for grabs.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants