Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some users in the seed do not have an 'invited at' . That has caused testing issues. Can we fix it? #4689

Closed
1 task
cielf opened this issue Sep 30, 2024 · 3 comments · Fixed by #4705
Closed
1 task

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 30, 2024

Summary

All users in the seed should have an "invitation sent at".

Why?

This has caused some testing issues in the past.

Details

See discussion on #3266. (If they don't have an invitation sent at, we run into problems when we check whether to send them an invitation)

Recreation of the problem we get when they don't have an invitation sent at (from #3266, but recreated 20240911)

bin/setup
bin/start
sign in as org_admin1
Partner Agencies | All Partners
choose Pawnee Parent Service
Users
In "invite user" fill in Name: User 1, email user_1@example.com
(that's the user with org_user status in the seed)
I got an Argument Error "nil can't be converted to a Time value" at line 45 in app/views/partner_users/_users.html.erb

It does send the email -- it's just failing on displaying?

Criteria for completion

  • All users in the seed have an "invited at".
@lsfernandes92
Copy link
Contributor

Hello @cielf! I've been following this project for a while, and with Hacktoberfest, I’ve come back to it. I still need to revisit the contributions section and get a better understanding of the application, but since I already have some experience with Rails backend development, do you think I could pick this one up?

@cielf
Copy link
Collaborator Author

cielf commented Oct 1, 2024

I don't see why not! Assigning it to you momentarially.

@lsfernandes92
Copy link
Contributor

Just a quick update on where I am... I'm still working on this. I briefly tried to run the project locally using Codespaces and a dev container on Tuesday, but it didn’t work out. Today, with more patience, I managed to get my local setup running! My plan for today is to reproduce the error locally, get a sense of the application’s models by taking a quick glance at the schema.rb file, and check the db/seeds.rb file to find references that deal with the "invited_at" field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants