Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model validations #43

Open
3 tasks
bjmllr opened this issue May 27, 2017 · 2 comments
Open
3 tasks

Model validations #43

bjmllr opened this issue May 27, 2017 · 2 comments
Labels
enhancement

Comments

@bjmllr
Copy link
Member

bjmllr commented May 27, 2017

Models which can be changed by a user directly should be checked for validity before changing the database.

  • Domain

Models which can be added by a scraper should be checked for validity before adding to the database.

  • Location
  • PhoneNumber
@bjmllr
Copy link
Member Author

bjmllr commented May 27, 2017

When a loader encounters an invalid model, should it just log the rejection and continue?

@gxespino
Copy link
Contributor

I think that's acceptable behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjmllr @gxespino