This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Use git sha as part of extension directory for git referenced gems. #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| 2.times do |i| | ||
| Dir.chdir(git_reader.path) do | ||
| File.write "ext/foo.c", <<-C |
There was a problem hiding this comment.
This doesn't work on Ruby 1.8, so this pull breaks the build. Can you fix it?
|
Thanks for the patch. I'll merge as soon as you fix the build on Ruby 1.8. :) |
|
Thanks! |
indirect
added a commit
that referenced
this pull request
Mar 31, 2014
Use git sha as part of extension directory for git referenced gems.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See issue #2947 which this pull request fixes.
Solution
Monkey patch Gem::Specification#extension_dir so that the source can override the extension directory name if it responds to extension_dir_name, similar to the monkey patch of full_gem_path.