Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Warnings with Bundler 1.9.1 from Molinillo #3516

Closed
zzak opened this issue Mar 26, 2015 · 8 comments
Closed

Warnings with Bundler 1.9.1 from Molinillo #3516

zzak opened this issue Mar 26, 2015 · 8 comments

Comments

@zzak
Copy link
Contributor

zzak commented Mar 26, 2015

Not sure if these were fixed in master yet.. or who to report it to..

/home/travis/.rvm/gems/ruby-2.2.0/gems/bundler-1.9.1/lib/bundler/vendor/molinillo/lib/molinillo/dependency_graph.rb:64: warning: possible reference to past scope - vertices
/home/travis/.rvm/gems/ruby-2.2.0/gems/bundler-1.9.1/lib/bundler/vendor/molinillo/lib/molinillo/resolution.rb:106: warning: private attribute?
/home/travis/.rvm/gems/ruby-2.2.0/gems/bundler-1.9.1/lib/bundler/vendor/molinillo/lib/molinillo/resolution.rb:109: warning: private attribute?
/home/travis/.rvm/gems/ruby-2.2.0/gems/bundler-1.9.1/lib/bundler/vendor/molinillo/lib/molinillo/resolution.rb:112: warning: private attribute?
@segiddins
Copy link
Member

Those warnings disagree with the Molinillo style guide.

@JuanitoFatas
Copy link
Contributor

Possible related: https://bugs.ruby-lang.org/issues/10967

@zzak
Copy link
Contributor Author

zzak commented Mar 26, 2015

I'm not familiar with Molinillo, or their style guide.. but it would be nice to fix these somehow.

Should I report this upstream?

@segiddins
Copy link
Member

@zzak I am Molinillo, and my/the CocoaPods style guide is definitely in favor of using private attributes over direct ivar access.

@indirect
Copy link
Member

We generally try to keep the Bundler codebase from containing any warnings, but the private attribute one seems especially weird/contested to me. :/

@segiddins
Copy link
Member

I just fixed the first warning on Molinillo master, but I'm not changing the use of private attributes -- that's a silly warning imho.

@segiddins
Copy link
Member

This is fixed in 1-9-stable.

@indirect
Copy link
Member

This will be part of 1.9.2, released shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants