Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Handle quotes in PATH #4326

Merged
merged 3 commits into from
Mar 1, 2016
Merged

Handle quotes in PATH #4326

merged 3 commits into from
Mar 1, 2016

Conversation

segiddins
Copy link
Member

Fixes #4323 and adds tests

@indirect
Copy link
Member

If I'm understanding this correctly, this change does not handle entries that use quotes around the path separator, which is the specific case that quotes are required for. For example, PATH=C:\ruby\bin;"C:\stuff;other stuff\bin".

@segiddins
Copy link
Member Author

@indirect correct, but it fixes the issue that was reported ;)

@indirect
Copy link
Member

@segiddins so now we're just knowingly waiting for the first person who has a path containing File::PATH_SEPARATOR, because it will be completely broken for them. 😂 😭

@segiddins
Copy link
Member Author

@indirect but no more broken than it is now. this is an improvement without regression. feel free to add a disabled test for the other scenario or hold up this PR until someone contributes that other half

@indirect
Copy link
Member

@segiddins yeah, yeah. I'm 👍 on this once the tests pass.

@segiddins
Copy link
Member Author

Ought to pass now

@segiddins
Copy link
Member Author

@homu r+

@homu
Copy link
Contributor

homu commented Mar 1, 2016

📌 Commit bd0f564 has been approved by segiddins

@homu
Copy link
Contributor

homu commented Mar 1, 2016

⚡ Test exempted - status

@homu homu merged commit bd0f564 into master Mar 1, 2016
homu added a commit that referenced this pull request Mar 1, 2016
Handle quotes in PATH

Fixes #4323 and adds tests
@segiddins segiddins deleted the seg-path-quotes branch March 1, 2016 04:18
@coilysiren coilysiren modified the milestone: Release Archive Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants