-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
fdd130e
to
f590c8b
Compare
If I'm understanding this correctly, this change does not handle entries that use quotes around the path separator, which is the specific case that quotes are required for. For example, |
@indirect correct, but it fixes the issue that was reported ;) |
@segiddins so now we're just knowingly waiting for the first person who has a path containing |
@indirect but no more broken than it is now. this is an improvement without regression. feel free to add a disabled test for the other scenario or hold up this PR until someone contributes that other half |
@segiddins yeah, yeah. I'm 👍 on this once the tests pass. |
Ought to pass now |
@homu r+ |
📌 Commit bd0f564 has been approved by |
⚡ Test exempted - status |
Handle quotes in PATH Fixes #4323 and adds tests
Fixes #4323 and adds tests