This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
fix standalone executable when dest of symlink #4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a spec covering the bug this fixes? Thanks! |
|
@segiddins Absolutely! Are there already specs for this part of the code? I looked for them, but I didn't find them, and I feel like I missed it. |
|
I'll have a look next time I'm at my computer, but I feel we might have a standalone_specs.rb? |
|
@segiddins I've dded a spec to confirm that running a symlink works. |
| require "tmpdir" | ||
| symlink = File.expand_path("rails", Dir.mktmpdir) | ||
| File.symlink(bundled_app("bin/rails"), symlink) | ||
| expect(`#{symlink} -v`.chomp).to eql "2.3.2" |
There was a problem hiding this comment.
sys_exec!("#{symlink} -v")
expect(out).to eq("2.3.2")There was a problem hiding this comment.
I'm paralleling the nearby test. Should I change it as well?
|
👍 from me other than the test comments |
|
@segiddins sorry I was away. I'm currently addressing the issues you brought up. |
When an executable is the destination of a symlink `__FILE__` contains the path to the symlink, rather than the actual path of the current file. Pathname#realpath resolves symlinks to get the actual location on disk.
|
Thanks! @homu r+ |
|
📌 Commit a14c2fb has been approved by |
homu
added a commit
that referenced
this pull request
Aug 15, 2016
…indirect fix standalone executable when dest of symlink When an executable is the destination of a symlink `__FILE__` contains the path to the symlink, rather than the actual path of the current file. `Pathname#realpath` resolves symlinks to get the actual location on disk.
|
💔 Test failed - status |
|
@homu retry |
homu
added a commit
that referenced
this pull request
Aug 15, 2016
…indirect fix standalone executable when dest of symlink When an executable is the destination of a symlink `__FILE__` contains the path to the symlink, rather than the actual path of the current file. `Pathname#realpath` resolves symlinks to get the actual location on disk.
|
☀️ Test successful - status |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an executable is the destination of a symlink
__FILE__containsthe path to the symlink, rather than the actual path of the current
file.
Pathname#realpathresolves symlinks to get the actual location on disk.