Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

[workaround] Use require instead of autoload for bundler/plugin/api #5010

Merged

Conversation

aycabta
Copy link
Contributor

@aycabta aycabta commented Sep 21, 2016

Please read #4981 (comment).

But it's elusive reproduction (and lack of test case) makes me think that the problem is a bit deeper and may recur.

I think so. This Pull Request is just workaround.

@indirect
Copy link
Member

indirect commented Oct 3, 2016

Merging this so that we at least have a fix for now. Hopefully #4981 will eventually produce a test case.

@homu r+

@homu
Copy link
Contributor

homu commented Oct 3, 2016

📌 Commit 4c32972 has been approved by indirect

@homu
Copy link
Contributor

homu commented Oct 3, 2016

⌛ Testing commit 4c32972 with merge 8168619...

homu added a commit that referenced this pull request Oct 3, 2016
…gin-api, r=indirect

[workaround] Use `require` instead of `autoload` for bundler/plugin/api

Please read #4981 (comment).

> But it's elusive reproduction (and lack of test case) makes me think that the problem is a bit deeper and may recur.

I think so. This Pull Request is just *workaround*.
@homu
Copy link
Contributor

homu commented Oct 3, 2016

☀️ Test successful - status

@homu homu merged commit 4c32972 into rubygems:master Oct 3, 2016
indirect pushed a commit that referenced this pull request Oct 11, 2016
…gin-api, r=indirect

[workaround] Use `require` instead of `autoload` for bundler/plugin/api

Please read #4981 (comment).

> But it's elusive reproduction (and lack of test case) makes me think that the problem is a bit deeper and may recur.

I think so. This Pull Request is just *workaround*.
0xced added a commit to 0xced/XCDYouTubeKit that referenced this pull request Oct 16, 2016
btsai added a commit to btsai/bundler that referenced this pull request Jan 29, 2017
This was originally a workaround fix in rubygems#5010, to prevent the following error in fastlane and rdoc on bundler 1.14.3, but the following commit undid this, and this errors is reappearing:
rubygems@6167ec8

```
gems/bundler-1.14.3/lib/bundler/rubygems_ext.rb:45:in `full_gem_path': uninitialized constant Bundler::Plugin::API::Source (NameError)
from /lib/ruby/site_ruby/2.0.0/rubygems/basic_specification.rb:144:in `block in full_require_paths'
```

This commit will revert that change.
@aycabta aycabta deleted the use-require-instead-of-autoload-for-plugin-api branch February 7, 2019 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants