You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And for each line like clients, prepend-rucio, prepend-release, push-tagged, push-latest, we essentially parse each part out in the 'Generate Docker Image Names' script (this step does not just generate image names, but actually determines whether images are actually pushed or not, so we should probably rename it)
Instead of doing this, we can rewrite the matrix to have stuff like prepend-rucio, prepend-release as boolean key/values, so that we don't need to do any regex parsing when generating the image name and determining whether to push it or not (which should likely also be faster):
We have this matrix:
containers/.github/workflows/docker-auto-build.yml
Lines 12 to 30 in e8e3ebf
And for each line like
clients, prepend-rucio, prepend-release, push-tagged, push-latest
, we essentially parse each part out in the 'Generate Docker Image Names' script (this step does not just generate image names, but actually determines whether images are actually pushed or not, so we should probably rename it)Instead of doing this, we can rewrite the matrix to have stuff like
prepend-rucio
,prepend-release
as boolean key/values, so that we don't need to do any regex parsing when generating the image name and determining whether to push it or not (which should likely also be faster):https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow
The text was updated successfully, but these errors were encountered: