Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Core Entities #297

Open
ThePhisch opened this issue Aug 17, 2023 · 3 comments
Open

Clean up Core Entities #297

ThePhisch opened this issue Aug 17, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ThePhisch
Copy link
Contributor

ThePhisch commented Aug 17, 2023

Description

Some core entities such as the ones stored in https://github.com/rucio/webui/blob/5cf28d4575d62600bca5d97856df27518b7e2a85/src/lib/infrastructure/data/view-model/page-did.d.ts are not in the appropriate folder lib/core/entity

@ThePhisch ThePhisch added the bug Something isn't working label Aug 17, 2023
@ThePhisch ThePhisch self-assigned this Aug 17, 2023
@maany maany assigned MytsV and unassigned ThePhisch Aug 1, 2024
@maany
Copy link
Member

maany commented Aug 13, 2024

@MytsV this refactor is independent of the UI and framework changes. Could you pick it up already :)

@MytsV
Copy link
Contributor

MytsV commented Aug 15, 2024

@MytsV this refactor is independent of the UI and framework changes. Could you pick it up already :)

Sorry, sometimes procrastination is about avoiding the easier tasks XD

@MytsV
Copy link
Contributor

MytsV commented Aug 15, 2024

The commit that seemingly did all of the refactoring is mentioned in #320. There's a bit of chaos in the view-model/create-rule.ts, but it might be better to review it while working on finishing off the Create Rule page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants