Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor compile time expressions #16

Merged
merged 9 commits into from
Dec 7, 2022

Conversation

koladilip
Copy link
Collaborator

@koladilip koladilip commented Dec 1, 2022

Description of the change

Add support for 2 stage compilation in single pass.
By default everything will be going through path processing and that is not desirable in some cases as users might want to process as javascrip paths.

Should we make javascript paths default or complex paths? Currently complex path processing are default.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

koladilip and others added 3 commits November 30, 2022 21:31
By default everything will be going through path processing and that is not desirable in some cases as users might want to process as javascrip paths.

Should we make javascript paths default or complex paths?
Currently complex path processing are default.
Add support for 2 stage compilation in single pass.
@koladilip koladilip requested a review from saikumarrs as a code owner December 1, 2022 07:50
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 3063/3063
🟢 Branches 100% 819/819
🟢 Functions 100% 242/242
🟢 Lines 100% 3063/3063

Test suite run success

68 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from d047ec2

@koladilip koladilip mentioned this pull request Dec 1, 2022
9 tasks
@koladilip koladilip force-pushed the refactor.compile-time-expressions branch 6 times, most recently from bd69411 to 167f41a Compare December 1, 2022 20:19
@koladilip koladilip force-pushed the refactor.compile-time-expressions branch 11 times, most recently from 6de6d51 to c345923 Compare December 7, 2022 10:22
@koladilip koladilip force-pushed the refactor.compile-time-expressions branch from c345923 to d047ec2 Compare December 7, 2022 10:56
@koladilip koladilip merged commit cae81bf into main Dec 7, 2022
@koladilip koladilip deleted the refactor.compile-time-expressions branch December 7, 2022 11:00
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants