-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor compile time expressions #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default everything will be going through path processing and that is not desirable in some cases as users might want to process as javascrip paths. Should we make javascript paths default or complex paths? Currently complex path processing are default.
Add support for 2 stage compilation in single pass.
Coverage report
Test suite run success68 tests passing in 1 suite. Report generated by 🧪jest coverage report action from d047ec2 |
9 tasks
koladilip
force-pushed
the
refactor.compile-time-expressions
branch
6 times, most recently
from
December 1, 2022 20:19
bd69411
to
167f41a
Compare
koladilip
force-pushed
the
refactor.compile-time-expressions
branch
11 times, most recently
from
December 7, 2022 10:22
6de6d51
to
c345923
Compare
koladilip
force-pushed
the
refactor.compile-time-expressions
branch
from
December 7, 2022 10:56
c345923
to
d047ec2
Compare
saikumarrs
approved these changes
Dec 7, 2022
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add support for 2 stage compilation in single pass.
By default everything will be going through path processing and that is not desirable in some cases as users might want to process as javascrip paths.
Should we make javascript paths default or complex paths? Currently complex path processing are default.
Checklists
Development
Code review